Recommend Figure.timestamp and remove timestamp (U) alias from all plotting methods #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The warning message looks like this: >>> import pygmt
>>> fig = pygmt.Figure()
>>> fig.basemap(region=[0, 10, 0, 10], projection="X10c/10c", frame=True, U=True)
<ipython-input-3-47b2c09a10fd>:1: SyntaxWarning: Parameter 'U' and 'timestamp' is deprecated since v0.8.0. Use Figure.timestamp() instead.
fig.basemap(region=[0, 10, 0, 10], projection="X10c/10c", frame=True, U=True)
>>> fig.show()
>>> import pygmt
>>> fig = pygmt.Figure()
>>> fig.basemap(region=[0, 10, 0, 10], projection="X10c/10c", frame=True, timestamp=True)
<ipython-input-7-eff609310ed5>:1: SyntaxWarning: Parameter 'U' and 'timestamp' is deprecated since v0.8.0. Use Figure.timestamp() instead.
fig.basemap(region=[0, 10, 0, 10], projection="X10c/10c", frame=True, timestamp=True)
>>> fig.show() |
Merged
27 tasks
weiji14
reviewed
Nov 4, 2022
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
NOTE: Figure.timestamp is not implemented yet.
Will definitely need to implement this before this PR can be approved 🙂
Co-authored-by: Wei Ji <[email protected]>
seisman
commented
Nov 5, 2022
6 tasks
seisman
changed the title
seisman
changed the title
seisman
commented
Mar 3, 2023
seisman
added
final review call
seisman
removed
the
final review call
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Similar to #2071.
The purpose of this PR is to remove timestamp (U) alias and recommend use
Figure.timestampinstead.NOTE:
Figure.timestampis not implemented yet.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version